The invention provides a preparation method for similarly coralloid NiSe@NC. The preparation method comprises the following steps that S1, 4,4'-dipyridyl, trimesinic acid and nickel nitrate are dissolved in N,N-dimethylformamide sequentially, after stirring is conducted for 35 minutes at room temperature, the temperature is increased to 120-130 DEG C at the rate of 5-10 DEG C, thermal reaction isconducted for 60-70 h, and Ni-MOFs are obtained; and S2, selenium powder and the Ni-MOFs are heated to 500-800 DEG C at the rate of 1-5 DEG C/min at the argon atmosphere, and after 1-3 h of heat preservation, the similarly coralloid NiSe@NC is obtained. Compared with the prior art, the preparation method has the following beneficial effects that the metal organic frameworks with nickel as the center serve as the precursor, through a one-step in-situ selenylation strategy, the coralloid NiSe@NC is obtained, then the structure can provide abundant catalytic active sites, good electrocatalysis hydrogen production and oxygen production performance is shown, 60 and 320 mV overpotential and 53 and 101 mV dec<-1> Tafel slope are achieved, and the similarly coralloid NiSe@NC can serve as a bifunctional electrocatalyst for electrolysis hydrogen evolution and oxygen evolution.