The invention discloses a terephthalic acid uranyl coordination compound photocatalyst and a preparation method thereof, wherein the molecular formula of the photocatalyst is (H2-4,4'-bpy)[(UO2)2(TPA)3][4,4'-bpy=4,4'-bipyridine, TPA=terephthalic acid], the photocatalyst is yellow powder capable of being screened with a 100-mesh sieve and having a purity of not less than 99%, belongs to a tetragonal system, and has a p4<->21c space group structure, and the crystal cell parameters comprise that a is 23.203(3)angstrom, b is 23.203(3)angstrom, and c is 20.222(4)angstrom. According to the present invention, under the irradiation of an xenon lamp light source capable of simulating sunlight, with the photocatalyst, the RhB solution with the concentration of 20 mg/L can be degraded to 28.6% within 105 min; compared to the traditional TiO2, the photocatalyst of the present invention has the advantage of visible light response, and is the photocatalyst having good photocatalysis performance; and the preparation method has advantages of simple and easy-performing process, low requirements on equipment, and the like.