The invention discloses a short-hole-channel ordered mesoporous silica-sulfur-indium-zinc composite photocatalyst as well as a preparation method and application thereof. The short-hole-channel ordered mesoporous silica-sulfur-indium-zinc composite photocatalyst is prepared through the following steps of mixing ethyl orthosilicate with ZrOCl2, zinc salt, indium salt and a reducing agent so as to obtain a mixture, in the presence of a surfactant, sequentially performing sol-gel treatment, hydrothermal treatment and alcohol ultrasonic treatment, performing sucking filtration, performing cleaning and performing drying. According to the photocatalyst, the integration of adsorption and photocatalytic oxidation is realized, the photocatalyst has high adsorption properties and high photocatalytic activity on volatile organic compounds (VOCs), and hydroxyl radicals produced on the surface of a catalyst can effectively degrade the VOCs adsorbed and enriched by materials in an in-situ manner, so that the reaction rate and the reaction efficiency of photocatalytic degradation on the VOCs can be substantially improved, the photocatalyst can be used as an adsorbent or the photocatalyst for organic contaminants in the field of environmental protection, and the photocatalyst has wide environmental protection application potential.