The invention discloses a preparation method of a visible light catalyst. Compared with the prior art, the invention adopts inexpensive, non-toxic and harmless urea as the raw material, with no need for highly toxic raw materials. By controlling the calcination temperature, C3N4 can be prepared, thus being in favor of environment protection. The invention also provides a preparation method of a visible light catalyst, comprising the steps of: preparing C3N4 according to the above process; mixing the obtained C3N4 with a modifier in a solvent for reaction, drying the reaction product, thus obtaining the visible light catalyst. The modifier can be an Fe source compound, a Cu source compound, a Zn source compound, a V source compound, a W source compound, a Pt source compound, an Au source compound or a Pd source compound. The method of the invention employs an immersion method for C3N4 metal ion modification, so that metal ions can adsorb the C3N4 surface, thus inhibiting photoinduced charge recombination. Therefore, the visible light catalyst prepared by the preparation method provided in the invention has a high photo catalytic performance.