The invention relates to the field of novel catalytic materials, specifically to a preparation method for an Fe-N-C catalyst with waste shaddock peel as a carbon source. The preparation method comprises the following steps: S1, smashing the shaddock peel, and carrying out pretreatment so as to obtain dried shaddock peel; adding the dried shaddock peel and iron salt into deionized water, and carrying out stirring, drying and grinding so as to obtain mixed powder; and S2, calcining the mixed powder obtained in the step S1 in an ammonia gas atmosphere, and after completion of calcination, carrying out acid treatment so as to obtain the Fe-N-C catalyst. The method provided by the invention does not need to use a high-cost carbon material as a precursor, uses the shaddock peel as the carbon source, forms the Fe-N-C catalyst and pyrolyzes the shaddock peel into a mesoporous carbon material at the same time, and is a method for in-situ generation of a carbon carrier; the waste shaddock peel realizes cyclic utilization; and the Fe-N-C catalyst obtained by using the preparation method provided by the invention has the advantages of large specific surface area, high porosity, a large numberof mesopores, high purity and more excellent oxygen-reduction electrocatalytic performance.