The invention relates to a preparation method of a bismuth oxyhalide/bismuth oxide visible-light photocatalyst and belongs to the field of visible-light photocatalyst preparation. The method comprises the following steps: dissolving bismuth nitrate in a salpeter solution, adjusting pH with alkali lye, stirring, filtering, washing, drying, calcining at high temperature of 300-600 DEG C for 3-10 hours to prepare yellow bismuth oxide; adding a proper amount of hydrochloric acid, hydrobromic acid or hydroiodic acid with a certain concentration into the prepared bismuth oxide, carrying out an ultrasonic reaction, carrying out centrifugal separation, and drying at constant temperature of 50-100 DEG C for 4-10 hours to obtain the bismuth oxyhalide/bismuth oxide photocatalyst. The method can be carried out at room temperature and at normal pressure. Equipment is simple and easy to operate, can be put into practical use and has a potential application in industrial production. According to the prepared bismuth oxyhalide/bismuth oxide visible-light photocatalyst, the problem of high photo-generated electron and carrier recombination rate is solved effectively, and photocatalytic performance is greatly enhanced.